xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r384311198
########## File path: arch/arm/src/Makefile ########## @@ -80,6 +80,10 @@ endif # The "head" object HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT)) +ifneq ($(STARTUP_OBJS),) + # Assume C by default + STARTUP_COBJS ?= $(STARTUP_OBJS) +endif STARTUP_OBJS ?= $(HEAD_OBJ) Review comment: How about we remove line 83 to 87, and put $(STARTUP_OBJS) to line 175 directly? it doesn't make sense to assign HEAD_OBJ to STARTUP_OBJS if it is empty because HEAD_OBJ is for kernel startup and never suitable for userspace startup. Also, we need modify other arch to ensure crt0.c get compiled. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
