xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385589116
########## File path: arch/arm/src/Makefile ########## @@ -80,6 +80,10 @@ endif # The "head" object HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT)) +ifneq ($(STARTUP_OBJS),) + # Assume C by default + STARTUP_COBJS ?= $(STARTUP_OBJS) +endif STARTUP_OBJS ?= $(HEAD_OBJ) Review comment: > my understanding/assumption was that: > > * the export target is to collect things necessary to build and link apps Yes, export target is just for apps initialization. > * in case of non-KERNEL builds, it can includes HEAD_OBJ No, because HEAD_OBJ contain the machine start up code, launching apps linked with HEAD_OBJ most likely will generate the panic in any build mode. Can you imagine the result that HEAD_OBJ code(initialize the machine) run more than once? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
