xiaoxiang781216 commented on a change in pull request #101: Make sure 
examples/elf testbuild pass in parallel build
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/101#discussion_r384311328
 
 

 ##########
 File path: examples/elf/Makefile
 ##########
 @@ -57,6 +57,8 @@ else
   FSIMG_HDR = $(TESTS_DIR)/cromfs.h
 endif
 
+elf_main.c: tests/symtab.c
 
 Review comment:
   Yes, if we let elf_main.c depends on tests/symtab.c, then make know that it 
should build symtab.c then test before elf_main.c, but if we change elf_main.c 
depends on $(FSIMG_HDR), but without any action, then how make ensure the 
header generated before it start to compile elf_main.c?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to