yamt commented on a change in pull request #101: Make sure examples/elf testbuild pass in parallel build URL: https://github.com/apache/incubator-nuttx-apps/pull/101#discussion_r384316989
########## File path: examples/elf/Makefile ########## @@ -57,6 +57,8 @@ else FSIMG_HDR = $(TESTS_DIR)/cromfs.h endif +elf_main.c: tests/symtab.c Review comment: * symtab.c and $(FSIMG_HDR) are built with the same rule (L62-63) * elf_main.c (well, strictly speaking elf_main.o) depends on $(FSIMG_HDR) and dirlist.h, not symtab.c * usually Make.dep will know elf_main.o depends on tests/dirlist.h (it was the reason for 45bcfa8b2eb1b0a84214a2bfc23f555ad8cf135e) i don't understand why you prefer to make this depend on symtab.c over those headers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
