xiaoxiang781216 edited a comment on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597012524 > I don't understand what's wrong with nxstyle? Here is the recent nxstyle change which may affect the report: https://github.com/apache/incubator-nuttx/pull/487 https://github.com/apache/incubator-nuttx/pull/496 > Your link says: > > .github:1 > > Process completed with exit code 1. > > what this means? > Which means the patch has some style issue need to fix before merging. > There are warnings in arch/arm/src/stm32h7/stm32h7x7xx_rcc.c and arch/arm/src/stm32h7/hardware/stm32h7x3xx_rcc.h but that's not my fault. Should I fix someone else's warnings? Good question, you can express your opinion in this email loop: https://lists.apache.org/thread.html/r6e7b2ed2d5ca1d5b49c5898b591182a8d7475bee2d5de344c026b3f5%40<dev.nuttx.apache.org>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
