patacongo commented on a change in pull request #459: stm32h7: support SDRAM 
via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#discussion_r390306059
 
 

 ##########
 File path: arch/arm/src/stm32h7/stm32_allocateheap.c
 ##########
 @@ -246,6 +249,14 @@ void up_allocate_heap(FAR void **heap_start, size_t 
*heap_size)
 
   up_heap_color(*heap_start, *heap_size);
 #endif
+
+#if defined(CONFIG_DEBUG_FEATURES)
+
+  /* Display memory ranges to help debugging */
+
+  _info("%uKb of SRAM at %p\n", *heap_size / 1024, *heap_start);
 
 Review comment:
   In most cases, _info or minfo will not work when called from 
up_allocateheap().  up_allocateheap() is called earlier in the initialization 
sequence than is the logic that initialzes the syslog output.  Do you actually 
see output?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to