xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597173905
 
 
   > @xiaoxiang781216 First, note the weird failure mode of this check. Looks 
like a tool failure:
   > 
   > ```
   > Check failure on line 1 in .github
   > @github-actions github-actions / check
   > .github#L1
   > Process completed with exit code 1.
   > ```
   > 
   
   I just saw this:
   
![image](https://user-images.githubusercontent.com/18066964/76332803-c9497700-632b-11ea-96d4-cb3e2e8fb0c6.png)
   The report looks right.
   
   > We need to be very careful with any automated header changes. The are some 
execptions to almost every rule. Some people (inappropriately) added copyright 
to code. It is very common for people to take my file, modify a line or two and 
add themselves to the Copyright holders.
   >
   
   We can convert the files which don't have any doubt first, otherwise we can 
never finish the copyright work item.
    
   > There are also controversial files that we need to handle separately. So 
any tool would have to carefully check that (1) only one person claims to hold 
a copyright and (2) that person is on e the list of people who have granted 
software to the ASF.
   > 
   
   It's simple, we convert the files step by step:
   1.Convert the files which declare that you are the author
   2.Convert the files which declare Sony and his employee are author
   ...
   This positive search and conversion ensure we don't change the license 
accidently.
   
   > Has Sony and Pinecone official submitted SGAs? Or is this this just a 
verbal permission to change copyrights. The safest thing would be if you were 
to change all Pinecone copyrighted code, not someone else.
   > 
   
   We can submit SGA, where is the document for the workflow?
   
   > I have submitted an SGA.
   > 
   > Others have granted permission to change the copyrights: Ken Pettit and 
others, but we should formalized that process somehow.
   > 
   > This discussion belong on the dev list!
   
   Since the workflow is almost done, I think it's right time to disscuss 
license. Could you start a thread to collect the community feedback?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to