xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers. URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597238644 > @xiaoxiang781216 Thanks for the merge! > > Are you planning to write a tools to do the header changes? Or would you do them by hand. If you do them by hand, I will be happy to help out. it is really very easy and very fast (and probably safest). > Maybe we can reuse and improve @adamfeuer 's tool, @adamfeuer are you interesting with the work? > The probably is that every file you modify will also have to have nxstyle ran against it .. either before or after the PR. Yes, I suggest that we bypass the style check for license PR because: 1.It's hard to audit or revert license patch if we do style and license modification at the same time. 2.License patch just change the comment, it isn't likely to introduce the new style issue or build break.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
