xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers. URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597433124 > Hi, > We already run fossology and generate the report: https://fossology.brennanashton.com/repo/ <https://fossology.brennanashton.com/repo/> I also take one day to read it's document, but I can't find the tutorial to modify the license in batch. > Fossology can detect the licenses, you can update headers in groups, you could also use it to general a list of file to change and use your script to change those. Using it will make your life a lot easier. It also mean people can review and see any mistakes. It not only a tool for generating reports and it can work on a changing code base. Could you point me a link which describe the header updating process from fossology web ui? > Can we pass the apache license criteria just by just changing Greg's copyright? > I’m not sure what you mean by license criteria. I mean NuttX can graduate to the apache top level project by just changing Greg's copyright. > There is the ASF header and copyright policy [1]. For files developed at the ASF or donated as part of a grant the header must change to be the ASF one. [2] For all other files the ASF headers MUST remain unchanged. [3]. We only have a grant from Gregory so should not be changing headers on any files that are copyright other people or companies. Does that make it clearer? That's why I suggest that we just modify the files owner by Greg first, I don't see any reason we can't do this now. Yes, we need take care, but we also need make a progress. > If at the ASF (and not previously) you make major modifications to a 3rd party file you might consider changing the header, the PPMC would need to discuss this on a case by case basis. Given the code has just arrived at the ASFI guess it's unlikely that there are any files that meet that criteria. So this is how I would treat files: - All files that are copyright Gregory and have been entirely developed in the NuttX project should be changed to use the Apache header - Any files with a copyright other than Gregory’s should stay as it is - Files that that are copyright Gregory but includes any code from outside the NuttX project or code that has an unclear provenance the headers should remain as they are. In some cases the history of the file may need to be looked at. Hopefully there's only a few cases of this and hopefully Gregory can identify those files. - Any new files created since teh project has come to the ASF needs to use the ASF header Thanks, Justin 1. https://www.apache.org/legal/src-headers.html 2. https://www.apache.org/legal/src-headers.html#headers 3. https://www.apache.org/legal/src-headers.html#3party Let's summary my understand: 1.Change the file owned by Greg to Apache license 2.Ensure all new file declared with Apache license 3.Review license in the rest files if the patch make a significant change Does we follow the above requirement? IMPC don't block NuttX leaving incubation due to license issue.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
