xiaoxiang781216 commented on a change in pull request #558: libs/libc/netdb/lib_dnsaddserver.c: Fix wrong fopen() mode. URL: https://github.com/apache/incubator-nuttx/pull/558#discussion_r392287982
########## File path: libs/libc/netdb/lib_dnsaddserver.c ########## @@ -87,7 +87,7 @@ int dns_add_nameserver(FAR const struct sockaddr *addr, socklen_t addrlen) int status; int ret; - stream = fopen(CONFIG_NETDB_RESOLVCONF_PATH, "at"); + stream = fopen(CONFIG_NETDB_RESOLVCONF_PATH, "r"); Review comment: > i guess the original code meant "a". > some fopen implementations recognize "t" as "text mode". Yes, @yamt your analysis is right, but "t" isn't specified in standard: https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html And since dns_add_nameserver never read from the opened stream, so the better fix is changed to "a". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
