patacongo commented on a change in pull request #558: libs/libc/netdb/lib_dnsaddserver.c: Fix wrong fopen() mode. URL: https://github.com/apache/incubator-nuttx/pull/558#discussion_r392525334
########## File path: libs/libc/netdb/lib_dnsaddserver.c ########## @@ -87,7 +87,7 @@ int dns_add_nameserver(FAR const struct sockaddr *addr, socklen_t addrlen) int status; int ret; - stream = fopen(CONFIG_NETDB_RESOLVCONF_PATH, "at"); + stream = fopen(CONFIG_NETDB_RESOLVCONF_PATH, "r"); Review comment: > If the above is correct, then at the present time the argument should be "r" but would have to be revisited if the capability of DHCPC were improved. Hmm.. but clearly I am mistaken because libs/libc/netdb/lib_dnsaddserver.c does, indeed, write to /etc/resolv.conf ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
