[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

[GitBox]

davids5 commented on a change in pull request #745: [DO NOT MERGE] 
arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408069455
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   @hartmannathan - 
   
   
   
![image](https://user-images.githubusercontent.com/1945821/79220829-9d794f80-7e09-11ea-82cd-6ecc48113b75.png)
   
   I would think the RCC sets up the OSC it if is enabled and from the above,( 
If I have the correct datasheet) I do not see any AF0-14 for PH0 and 1, 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services