hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408173664
########## File path: arch/arm/include/stm32h7/chip.h ########## @@ -53,16 +53,40 @@ * * PART PACKAGE * ----------- ---------------- + * STM32H7x3Ax UFBGA169 Review comment: Yes, in all the STM32H7x3xx, PH0 and PH1 have only one alternate function: AF15, EVENTOUT. And, these pins can be GPIOs if not used for the OSC. So, which of the following would you prefer? - **STM32H7_NGPIO** defined to 6 (GPIOA thru GPIOF) and ignore GPIOH, or - **STM32H7_NGPIO** defined to 8 (GPIOA thru GPIOH), and add a **CONFIG_STM32H7_HAVE_GPIOG** to Kconfig. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
