patacongo commented on a change in pull request #965:
URL: https://github.com/apache/incubator-nuttx/pull/965#discussion_r420119455
##########
File path: syscall/syscall.csv
##########
@@ -42,7 +41,7 @@
"if_indextoname","net/if.h","defined(CONFIG_NETDEV_IFINDEX)","FAR char
*","unsigned int","FAR char *"
"if_nametoindex","net/if.h","defined(CONFIG_NETDEV_IFINDEX)","unsigned
int","FAR const char *"
"insmod","nuttx/module.h","defined(CONFIG_MODULE)","FAR void *","FAR const
char *","FAR const char *"
-"ioctl","sys/ioctl.h","!defined(CONFIG_LIBC_IOCTL_VARIADIC)","int","int","int","unsigned
long"
+"ioctl","sys/ioctl.h","","int","int","int","..."
Review comment:
... will not work in system calls. You must follow the patter of
vsyslog:
"nx_vsyslog","nuttx/syslog/syslog.h","","int","int","FAR const IPTR
char*","FAR va_list*"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
