xiaoxiang781216 commented on a change in pull request #965:
URL: https://github.com/apache/incubator-nuttx/pull/965#discussion_r420143499
##########
File path: syscall/syscall_stublookup.c
##########
@@ -189,13 +189,9 @@ uintptr_t STUB_nx_vsyslog(int nbr, uintptr_t parm1,
uintptr_t parm2,
*/
uintptr_t STUB_close(int nbr, uintptr_t parm1);
-#ifdef CONFIG_LIBC_IOCTL_VARIADIC
-uintptr_t STUB_fs_ioctl(int nbr, uintptr_t parm1, uintptr_t parm2,
- uintptr_t parm3);
-#else
uintptr_t STUB_ioctl(int nbr, uintptr_t parm1, uintptr_t parm2,
- uintptr_t parm3);
-#endif
+ uintptr_t parm3, uintptr_t parm4, uintptr_t parm5,
+ uintptr_t parm6);
Review comment:
But, I just follow open/fcntl/sem_open/mq_open/prctl approach. Both
method(open .v.s. syslog) work correctly, I select the current one just because
ioctl is more like these functions than syslog. I guess that syslog use a
different way just because syslog may pass arguments more than 6, but other
just need one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
