xiaoxiang781216 commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625233186
Actually, I don't have any personal preference:). Following the rule(either state in document explicitly or represent in the code base) as much as possible is my most favor. We may introduce some new symbol which is good at that time, but not good at the later since the context change. For example, clock_systimer looks good at the beginning, but it become inconsistent with other similiar function after we add clock_systimespec, clock_getime.... Now, we have decide what we should do next: 1.Keep it as before. then the inconsistence keep increasing and finally we mayn't have a rule to follow. 2.Refactor the code base to make it consistence again. We don't have choice for the standard defined symbols, but we have the choice for NuttX's symbols. Here is another example you need decide: https://github.com/apache/incubator-nuttx/pull/990/commits/4bb943a0c0ab173d7f5eb0178fd3a332726ce861 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
