xiaoxiang781216 commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625242733
> > Here is another example you need decide: > > [4bb943a](https://github.com/apache/incubator-nuttx/commit/4bb943a0c0ab173d7f5eb0178fd3a332726ce861) > > Yes, that is the wrong naming. **This is in complete complet conflict with what I have been trying to do please remove this commit! I have get modifying names to INCLUDE the _ in the name. I have been trying follow a pattern of: > > ``` > <subssystem>_<action>_<object> > ``` > > So the name reads like a sentence who = sched, action = get, get what = stackinfo > > Please DO NOT CHANGE THIS NAME. We must work together and not against each other. Picked that name because I want it EXACTLY as it is.** But there are many name already violative your rule: sched_getaffinity sched_getcpu sched_getparam sched_getscheduler sched_getstreams Even NuttX special function: sem_setprotocol sem_getprotocol How we handle these symbol? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
