yamt commented on code in PR #2241:
URL: https://github.com/apache/nuttx-apps/pull/2241#discussion_r1442493254
##########
interpreters/wamr/Kconfig:
##########
@@ -103,10 +103,9 @@ config INTERPRETERS_WAMR_ENABLE_SPEC_TEST
config INTERPRETERS_WAMR_STACK_GUARD_SIZE
int "Custom stack guard size"
- default 0
+ default 1024
Review Comment:
because your assumption is wrong?
at least in the current wamr aot implementation, a caller doesn't have
precise knowledge about how much stack the callee consumes. the callees need to
check the overflow by itself and the check itself might consume stack. (thus
the small amount of stack is reserved here.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
