yamt commented on code in PR #2241:
URL: https://github.com/apache/nuttx-apps/pull/2241#discussion_r1458637470
##########
interpreters/wamr/Kconfig:
##########
@@ -103,10 +103,18 @@ config INTERPRETERS_WAMR_ENABLE_SPEC_TEST
config INTERPRETERS_WAMR_STACK_GUARD_SIZE
int "Custom stack guard size"
- default 0
+ default 1024
---help---
- Reserve some space in stack as guard to detect stack overflow,
- use stack base by default but may not safe enough.
+ Reserve some space in stack as guard to detect stack overflow.
+
+ Please consider this extra stack consumption when deciding the
stack
+ size of your NuttX task on which you run WAMR.
+
+ The default value here (1024) was chosen to match the default
value on
+ the majority of other platforms, including Linux. It also
matches
+ the expections in the WAMR AoT compiler.
+ On the other hand, it might be a bit larger than what's strictly
+ necessary, especially for typical NuttX targets.
Review Comment:
just because it's difficult to fine tune this kind of things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
