yf13 commented on code in PR #11489: URL: https://github.com/apache/nuttx/pull/11489#discussion_r1443753909
########## tools/k230/Config.mk: ########## @@ -0,0 +1,39 @@ +############################################################################ +# tools/k230/Config.mk +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +# These are the macros that will be used in the NuttX make system to compile +# and assembly source files and to insert the resulting object files into an +# archive. These replace the default definitions at tools/Config.mk + +# POSTBUILD -- Perform post build operations + +# kernel build warning ROMFS lacking case +ifeq ($(CONFIG_BUILD_KERNEL),y) +ifeq ($(wildcard $(TOPDIR)/arch/risc-v/src/board/romfs_boot.c),) +define POSTBUILD Review Comment: I can't get you, can you elobarate? The purpose is to show a POSTBUILD message to warn that the build with stub ROMFS is not for trying on target. Later upon rebuild with real ROMFS, another POSTBUILD message will confirm that we can move ahead. I saw existing POSTBUILD definitions are mostly in `tools/*/Config.mk`. Did you mean that we should put POSTBUILD definitions in "Make.defs"? I guess the `$(wildcard)` here can be replaced with something like `K230_ROMFS_STUB` or existence of stub source in `CSRCS` , which I haven't tried yet. If you mean this condition judge only, then I think I can try if I can rewrite them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
