xiaoxiang781216 commented on code in PR #11489: URL: https://github.com/apache/nuttx/pull/11489#discussion_r1443893684
########## tools/k230/Config.mk: ########## @@ -0,0 +1,39 @@ +############################################################################ +# tools/k230/Config.mk +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +# These are the macros that will be used in the NuttX make system to compile +# and assembly source files and to insert the resulting object files into an +# archive. These replace the default definitions at tools/Config.mk + +# POSTBUILD -- Perform post build operations + +# kernel build warning ROMFS lacking case +ifeq ($(CONFIG_BUILD_KERNEL),y) +ifeq ($(wildcard $(TOPDIR)/arch/risc-v/src/board/romfs_boot.c),) +define POSTBUILD Review Comment: Other boards put Config.mk into tools/*/Config.mk, because the folders contain additional tools to do some special work. But in your simple case, it's more suitable to define POST_BUILD in https://github.com/apache/nuttx/pull/11489/files#diff-f92b47a398e385fa574860609a99076bac7a71f13403db16b4a08253a9515b37 directly. BTW, why not fix romfs issue directly? @fxysunshine created a patch fixed the romfs issue in kernel/protected mode recently. @fxysunshine could you upstream the patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
