xiaoxiang781216 commented on code in PR #11620:
URL: https://github.com/apache/nuttx/pull/11620#discussion_r1469441940
##########
arch/risc-v/src/common/espressif/Bootloader.mk:
##########
@@ -1,5 +1,5 @@
############################################################################
-# arch/risc-v/src/espressif/Bootloader.mk
+# arch/risc-v/src/common/espressif/Bootloader.mk
Review Comment:
it's strange to putt espressif common code to arch/risc-v/src/common. Why
not put to arch/risc-v/src/espressif/common?
##########
arch/risc-v/Kconfig:
##########
@@ -304,20 +304,20 @@ config ARCH_FAMILY
config ARCH_CHIP
string
- default "fe310" if ARCH_CHIP_FE310
- default "k210" if ARCH_CHIP_K210
- default "litex" if ARCH_CHIP_LITEX
- default "bl602" if ARCH_CHIP_BL602
- default "esp32c3" if ARCH_CHIP_ESP32C3
- default "espressif" if ARCH_CHIP_ESPRESSIF
- default "c906" if ARCH_CHIP_C906
- default "mpfs" if ARCH_CHIP_MPFS
- default "rv32m1" if ARCH_CHIP_RV32M1
- default "qemu-rv" if ARCH_CHIP_QEMU_RV
- default "hpm6750" if ARCH_CHIP_HPM6750
- default "jh7110" if ARCH_CHIP_JH7110
- default "bl808" if ARCH_CHIP_BL808
- default "k230" if ARCH_CHIP_K230
+ default "fe310" if ARCH_CHIP_FE310
+ default "k210" if ARCH_CHIP_K210
+ default "litex" if ARCH_CHIP_LITEX
+ default "bl602" if ARCH_CHIP_BL602
+ default "esp32c3-legacy" if ARCH_CHIP_ESP32C3
Review Comment:
why not remove the legacy implementation directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
