tmedicci commented on code in PR #11620:
URL: https://github.com/apache/nuttx/pull/11620#discussion_r1469482982


##########
arch/risc-v/src/common/espressif/Bootloader.mk:
##########
@@ -1,5 +1,5 @@
 ############################################################################
-# arch/risc-v/src/espressif/Bootloader.mk
+# arch/risc-v/src/common/espressif/Bootloader.mk

Review Comment:
   > Also this approach avoids potential misunderstanding about actual src file 
path.
   
   @xiaoxiang781216 , about `arch/risc-v/src/espressif/common`: `espressif` 
doesn't refer to the chip itself (unlikely, for instance, ARM's 
`nuttx/arch/arm/src/armv7-a` which is also common to other chips). It refers to 
a set of sources that are shared between different Espressif chips. So, in 
order to keep consistency, we created an  `espressif` folder in 
`arch/risc-v/src/common/espressif`. That was the idea...
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to