patacongo edited a comment on pull request #1148:
URL: https://github.com/apache/incubator-nuttx/pull/1148#issuecomment-636189025
@xiaoxiang781216 @yamt Perhaps you could help verify this change on Linux
and macOS. I am still waiting for feedback from Johannes on his serious build
slowdown, but I think this will help build time significantly, but mostly on
Windows based platforms that have problems with fork(). If you could verify
that this change is good for you, I can do the final integration into the build
system.
Or you can if you want to. It would need:
1. A new target in Makefile.unix and Makefile.win like:
tools/incdir$(HOSTEXEEXT):
$(Q) $(MAKE) -C tools -f Makefile.host TOPDIR="$(TOPDIR)"
incdir$(HOSTEXEEXT)
2. And a change in Config.mk to use incdir$(HOSTEXEEXT) instead on incdir.sh
Nevermind... I submitted PR 1149 to bring incdir.c into the build system.
Please review this PR as much as possible and verify that it builds for you. I
decided to go ahead with PR 1149 because the PR check is the best way I have of
verifying the change and finding any bugs. Expect a few updates to this PR
before it will be ready to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
