patacongo opened a new pull request #1148:
URL: https://github.com/apache/incubator-nuttx/pull/1148
## Summary
Recent changes that replaced inline -I arguments with use of the script
incdir.sh cause large slow down in build times. This PR implements a new
version of that logic in C which is many, many times faster. It should
recovery the lost time and MORE.
## Impact
This change will have absolutely not impact. It simply adds the incdir.c
file to the NuttX tools/ directory. We will want to get a lot of road
experience with this change before we incorporate it into the build system. It
has been well excercised under Cygwin but needs to to be checked in other
platforms was well.
Since it has not impact, you should not hesitate to merge this change!
## Testing
In order to test the this change, I manually override the definition of
INCDIR from tools/Config.mk. I do these steps (for Cygwin):
1. tools/configure.sh -c stm32f4discovery:nsh
2. Edit Make.defs as shown below, then
3. make
$ diff -u boards/arm/stm32/stm32f4discovery/scripts/Make.defs Make.defs
--- boards/arm/stm32/stm32f4discovery/scripts/Make.defs 2020-05-26
07:39:23.201472900 -0600
+++ Make.defs 2020-05-29 13:13:19.123771500 -0600
@@ -37,6 +37,8 @@
include $(TOPDIR)/tools/Config.mk
include $(TOPDIR)/arch/arm/src/armv7-m/Toolchain.defs
+INCDIR = "$(TOPDIR)/tools/incdir.exe" -w
+
LDSCRIPT = ld.script
ARCHINCLUDES += ${shell $(INCDIR) -s "$(CC)" $(TOPDIR)$(DELIM)include}
If you are using Linux, you would change the -c to -l in the configure.sh
options and remove the -w from the incdir.exe options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
