yf13 commented on PR #12041: URL: https://github.com/apache/nuttx/pull/12041#issuecomment-2036688358
@pussuw and @xiaoxiang781216 as for `up_addrenv_map()`, I am fine to drop it from `nuttx/arch.h`. This however implies that we may need a similar thing likely in `mm/map` to wrap the `up_shmat()` as it can be shared between framebuffer and other drivers. Actually the `up_shmat()` parameter model lacks the `prot` argument and it is may be hard for implementation to use larger PTE entries as its input pages might be incontinuous pages. Maybe having `up_addrenv_map()` there it also worth as its parameter model is more generic and implementations can choose to use non-leaf PTE entries if the size is bigger? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
