xiaoxiang781216 commented on code in PR #12041: URL: https://github.com/apache/nuttx/pull/12041#discussion_r1569159476
########## include/nuttx/mm/map.h: ########## @@ -193,6 +193,42 @@ void vm_release_region(FAR struct mm_map_s *mm, FAR void *vaddr, #endif +#ifdef CONFIG_MM_UMAP + +/**************************************************************************** + * Name: vm_map_region + * + * Description: + * Allocate virtual memory and maps physical memory range into user space + * of the current process. + * + * Input Parameters: + * paddr - Starting physical address + * size - Size of the address range + * + * Returned Value: + * Virtual address of the range, or NULL if error + * + ****************************************************************************/ + +uintptr_t vm_map_region(uintptr_t paddr, size_t size); Review Comment: where is this function implemented? ########## include/nuttx/addrenv.h: ########## @@ -193,7 +193,9 @@ # define ARCH_SHM_MAXPAGES (CONFIG_ARCH_SHM_NPAGES * CONFIG_ARCH_SHM_MAXREGIONS) # define ARCH_SHM_REGIONSIZE (CONFIG_ARCH_SHM_NPAGES * CONFIG_MM_PGSIZE) # define ARCH_SHM_SIZE (CONFIG_ARCH_SHM_MAXREGIONS * ARCH_SHM_REGIONSIZE) Review Comment: why not rename SHM_xxx to general name directly, but add UDEV_xxx? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
