yf13 commented on code in PR #12041: URL: https://github.com/apache/nuttx/pull/12041#discussion_r1571504909
########## include/nuttx/addrenv.h: ########## @@ -193,7 +193,9 @@ # define ARCH_SHM_MAXPAGES (CONFIG_ARCH_SHM_NPAGES * CONFIG_ARCH_SHM_MAXREGIONS) # define ARCH_SHM_REGIONSIZE (CONFIG_ARCH_SHM_NPAGES * CONFIG_MM_PGSIZE) # define ARCH_SHM_SIZE (CONFIG_ARCH_SHM_MAXREGIONS * ARCH_SHM_REGIONSIZE) Review Comment: > > You define `# define ARCH_SHM_VEND (CONFIG_ARCH_SHM_VBASE + ARCH_UMAP_SIZE - 1)` which proves that the UMAP region is just a region of SHM. If your goal is to remove naming confusion, this does not help in my opinion. This will be `ARCH_UMAP_VEND` later if we agree that `UMAP` region is composed of `SHM` and `UDEV`. To reuse existing SHM configs, my confusion comes from the ARCH_SHM_MAXREGIONS thing as it affects the total virtual region size. Can we remove it from the ARCH_SHM_VEND calculations and simply let SHM_NPAGES defines the size? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
