yf13 commented on code in PR #12041: URL: https://github.com/apache/nuttx/pull/12041#discussion_r1573065687
########## include/nuttx/addrenv.h: ########## @@ -193,7 +193,9 @@ # define ARCH_SHM_MAXPAGES (CONFIG_ARCH_SHM_NPAGES * CONFIG_ARCH_SHM_MAXREGIONS) # define ARCH_SHM_REGIONSIZE (CONFIG_ARCH_SHM_NPAGES * CONFIG_MM_PGSIZE) # define ARCH_SHM_SIZE (CONFIG_ARCH_SHM_MAXREGIONS * ARCH_SHM_REGIONSIZE) Review Comment: @xiaoxiang781216 and @pussuw Okay, I will drop UDEV_NPAGES and revise comments for SHM_NPAGES and SHM_MAXREGIONS and also remove the latter from the region size calculations. Hope this can help to reduce confusions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
