lupyuen commented on PR #12178: URL: https://github.com/apache/nuttx/pull/12178#issuecomment-2067717609
Thanks @inochisa, I have some questions: 1. Have we tested on QEMU 32-bit and 64-bit? (Normally I attach NuttX Logs to my PRs) 2. There's a discussion here on IPI: https://github.com/apache/nuttx/issues/11930. Wonder if the PR will fix this issue? 3. Suggest we [squash the commits](https://lupyuen.github.io/articles/pr#squash-the-commits) into 1 commit, so it's easier for other devs to track the history. (Actually I wonder if we should have submitted as multiple smaller PRs) Please gimme some time to read and understand the code, also to test on Ox64. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
