inochisa commented on PR #12178: URL: https://github.com/apache/nuttx/pull/12178#issuecomment-2067831303
> 1. Have we tested on QEMU 32-bit and 64-bit? (Normally I attach [NuttX Test Logs](https://lupyuen.github.io/articles/pr#testing) to my PRs) Thanks for reminding, I have attached test log file. > 2. There's a discussion here on IPI: [Question about RISCV cpu_start #11930](https://github.com/apache/nuttx/issues/11930). Wonder if the PR will fix this issue? No luck, this is another problem. The change on IPI is mainly for using different IPI code in different mode. > 3. Suggest we [squash the commits](https://lupyuen.github.io/articles/pr#squash-the-commits) into 1 commit, so it's easier for other devs to track the history. (Actually I wonder if we should have submitted as multiple smaller PRs) I struggled whether to break this PR into several ones, or just squash them as a whole. But finally, I decide to submmit this PR as is. IPI change allows to using another change for S mode. dynamic stack allocation make a progress on booting with non-zero hart (which is kind of necessary for booting with SBI). and SSTC give better performance in S-mode. This three are important for qemu-rv S-mode. For the last commit, it is a squash commit. Because I have no idea to separate them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
