xiaoxiang781216 commented on PR #12303:
URL: https://github.com/apache/nuttx/pull/12303#issuecomment-2100919217
> @Gary-Hobson after your modification microADB is failing here:
>
> ```
> if (!uv_is_active((uv_handle_t*)&client->read_pipe)) {
> /* Restart read events */
> int ret = uv_read_start((uv_stream_t*)&client->read_pipe,
> usb_uv_allocate_frame,
> usb_uv_on_data_available);
> /* TODO check return code */
> assert(ret == 0);
> UNUSED(ret);
> }
> ```
>
> Seems like you need to replace "#define assert(f) (0)" with something like
"#define assert(f) (f && 0)".
>
can't not, since the spec require that assert shouldn't reference f when
NDEBUG is defined
> This is strange because UNUSED() should avoid the issue, but is not
working!
Yes. @Gary-Hobson please find the reason why UNUSED doesn't work as expect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
