xiaoxiang781216 commented on PR #12303: URL: https://github.com/apache/nuttx/pull/12303#issuecomment-2102789440
> > This is not correct. > > Please see how the ASSERT() definition was moved from [here](https://github.com/apache/nuttx/pull/12303/commits/5eaf6083c5c864d976841f45c48ae1a731b495fb#diff-d1f563977d4d567fcfa3de881a2bf7f6ae116fb2857c4f083734a105719a051eL126) to [here](https://github.com/apache/nuttx/pull/12303/commits/5eaf6083c5c864d976841f45c48ae1a731b495fb#diff-d1f563977d4d567fcfa3de881a2bf7f6ae116fb2857c4f083734a105719a051eR132), i.e. the macro was always active before and now it is conditionally active based on NDEBUG. > > Sorry, I checked again the code and it seems that I am wrong. Indeed the behavior is not changing now. > > As I understand this change has already happened [here](https://github.com/apache/nuttx/commit/a521fd7b82dec43871b4f56a6ae0d85d124158e9). > > However, the rest of the points I think that still hold. What is the value of having both `ASSERT()` and `assert()` now? ASSERT() is an internal api, so we can always reference the argument and avoid use UNUSED macro in many places. assert() is defined by standard, so we can't reference the argument if NDEBUG equals true and have to add UNUSED macro. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
