pkarashchenko commented on code in PR #12814: URL: https://github.com/apache/nuttx/pull/12814#discussion_r1699379119
########## boards/arm/stm32h7/nucleo-h743zi2/src/nucleo-h743zi2.h: ########## @@ -226,4 +226,8 @@ int stm32_pwm_setup(void); int stm32_qencoder_initialize(const char *devpath, int timer); #endif +#ifdef CONFIG_SYSTEMTICK_HOOK +void board_timerhook(void); Review Comment: prototype is already defined in `board.h` ########## boards/arm/stm32h7/nucleo-h745zi/src/nucleo-h745zi.h: ########## @@ -317,4 +317,8 @@ int stm32_pwm_setup(void); int stm32_qencoder_initialize(const char *devpath, int timer); #endif +#ifdef CONFIG_SYSTEMTICK_HOOK +void board_timerhook(void); Review Comment: prototype is already defined in `board.h` ########## boards/arm/stm32h7/nucleo-h745zi/src/stm32_bringup.c: ########## @@ -227,3 +231,13 @@ int stm32_bringup(void) return OK; } + +#ifdef CONFIG_SYSTEMTICK_HOOK + +sem_t g_waitsem; Review Comment: where the semaphore is consumed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
