casaroli commented on code in PR #2469: URL: https://github.com/apache/nuttx-apps/pull/2469#discussion_r1706412206
########## nshlib/nsh_parse.c: ########## @@ -275,8 +276,11 @@ static const char g_line_separator[] = "\"'#;\n"; #ifdef CONFIG_NSH_ARGCAT static const char g_arg_separator[] = "`$"; #endif -static const char g_redirect1[] = ">"; -static const char g_redirect2[] = ">>"; +static const char g_redirect_out1[] = ">"; +static const char g_redirect_out2[] = ">>"; +static const char g_redirect_in1[] = "<"; +static const char g_redirect_in2[] = "<<"; +static const char g_pipe[] = "|"; Review Comment: Yes. I need the pipe operator. I think a simple limited implementation can be done, but it is tricky and require more refactor. Same goes for heredoc (`<<` redirection). I kept it away from the current PR to avoid making it too big. We can do it in the current PR or in a separate PR. WDYT? Can we do in future PR but keep the checks in the parser? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
