casaroli commented on code in PR #2469:
URL: https://github.com/apache/nuttx-apps/pull/2469#discussion_r1706596857
##########
nshlib/nsh_parse.c:
##########
@@ -2685,45 +2750,118 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
argv[argc] = pbegin;
}
}
- }
-
- /* Check if the command should run in background */
+ else if (!strncmp(argv[argc], g_redirect_out2,
+ strlen(g_redirect_out2)))
Review Comment:
Sorry. I don't see how this is easily possible, as the first use is inside
the condition to `else if` and the two others are inside the `{}` block. Where
would this `len` be declared? We would also need a len to `g_redirect_out1` and
`g_redirect_in1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
