patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439837333
########## File path: include/nuttx/net/net.h ########## @@ -155,7 +155,8 @@ enum net_lltype_e NET_LL_BLUETOOTH, /* Bluetooth */ NET_LL_IEEE80211, /* IEEE 802.11 */ NET_LL_IEEE802154, /* IEEE 802.15.4 MAC */ - NET_LL_PKTRADIO /* Non-standard packet radio */ + NET_LL_PKTRADIO, /* Non-standard packet radio */ + NET_LL_MBIM Review comment: The integration into net/procfs/netdev_statistics.c is essential or else the ifconfig command will not work. net/netdev/netdev_lladdrsize.c is used to report the size of the MAC header. I don't think any of the forwarding applies. That is only when we have to reformat packets in order to forward them. I would need to check, but I think that the IOCTL stuff is only necessary for MAC-specific IOCTL support. I would have to examine the remaining to see what is and is not relevant. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org