patacongo commented on a change in pull request #1233:
URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439833437
##########
File path: net/netdev/netdev_register.c
##########
@@ -55,6 +55,7 @@
#define NETDEV_PAN_FORMAT "pan%d"
#define NETDEV_WLAN_FORMAT "wlan%d"
#define NETDEV_WPAN_FORMAT "wpan%d"
+#define NETDEV_MBIM_FORMAT "wwan%d"
Review comment:
No, the corrent naming here must be NETDEV_WWAN_FORMAT. There is no
conflict in this naming. Just like WLAN, there an many different MAC layers
that would share the wwlan naming. It is independent of MBIM.
Look at the other naming:
#define NETDEV_PAN_FORMAT "pan%d"
#define NETDEV_WLAN_FORMAT "wlan%d"
#define NETDEV_WPAN_FORMAT "wpan%d"
By comparison, this naming is ridiculous:
#define NETDEV_MBIM_FORMAT "wwan%d"
It MUST be NETDEV_WWAN_FORMAT for consistency. I think that is a must.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
