pkarashchenko commented on code in PR #13022:
URL: https://github.com/apache/nuttx/pull/13022#discussion_r1722187772
##########
arch/xtensa/src/esp32/esp32_wireless.c:
##########
@@ -351,6 +351,85 @@ static void esp_wifi_set_log_level(void)
* Public Functions
****************************************************************************/
+/****************************************************************************
+ * Name: esp_wifi_to_errno
+ *
+ * Description:
+ * Transform from ESP Wi-Fi error code to NuttX error code
+ *
+ * Input Parameters:
+ * err - ESP Wi-Fi error code
+ *
+ * Returned Value:
+ * NuttX error code defined in errno.h
+ *
+ ****************************************************************************/
+
+int32_t esp_wifi_to_errno(int err)
Review Comment:
Why errno return value is `int32_t` and not `int`?
##########
arch/risc-v/src/common/espressif/esp_start.c:
##########
@@ -470,15 +478,6 @@ void __esp_start(void)
showprogress('A');
- /* Clear .bss. We'll do this inline (vs. calling memset) just to be
- * certain that there are no issues with the state of global variables.
- */
-
- for (uint32_t *dest = (uint32_t *)_sbss; dest < (uint32_t *)_ebss; )
Review Comment:
So bss is not cleared elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
