tmedicci commented on code in PR #13022: URL: https://github.com/apache/nuttx/pull/13022#discussion_r1722217310
########## arch/xtensa/src/esp32/esp32_wireless.c: ########## @@ -351,6 +351,85 @@ static void esp_wifi_set_log_level(void) * Public Functions ****************************************************************************/ +/**************************************************************************** + * Name: esp_wifi_to_errno + * + * Description: + * Transform from ESP Wi-Fi error code to NuttX error code + * + * Input Parameters: + * err - ESP Wi-Fi error code + * + * Returned Value: + * NuttX error code defined in errno.h + * + ****************************************************************************/ + +int32_t esp_wifi_to_errno(int err) Review Comment: No specific reason. Similar functions for the other architectures use the same type (for RISC-V, for instance: https://github.com/apache/incubator-nuttx/blob/2c4963dcd6f9785d6d3e5b327e22fd995cbc81a7/arch/risc-v/src/common/espressif/esp_wifi_utils.h#L112). We can change it for `int` for all of them, I just kept the same for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
