yamt commented on PR #13222:
URL: https://github.com/apache/nuttx/pull/13222#issuecomment-2322757422

   > > I may have found a bug here. Let me debug it properly.
   > 
   > Confirmed. I'm sorry for the confusion. The tests regarding ESP32 + SMP 
without PSRAM failed because the change in #13249 is valid only when PSRAM is 
enabled, so we need to make it part of the general case. Can you commit the 
following to revert it and place it in the correct position:
   
   i created the commit in this PR. (is this what you meant? i'm not entirely 
sure why you didn't submit a separate PR by yourself.)
   when creating the commit, i tried to preserve metadata. but there might be 
some botches. it would be simpler to use git-format-patch next time.
   
   btw, are these rom functions documented somewhere? i was just making wild 
guesses from their names.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to