xiaoxiang781216 commented on code in PR #13519:
URL: https://github.com/apache/nuttx/pull/13519#discussion_r1764301266
##########
boards/arm/stm32/olimex-stm32-p407/configs/kmodule/defconfig:
##########
@@ -5,7 +5,6 @@
# You can then do "make savedefconfig" to generate a new defconfig file that
includes your
# modifications.
#
-# CONFIG_FS_REFCOUNT is not set
Review Comment:
let's add CONFIG_DEFAULT_SMALL?
##########
include/signal.h:
##########
@@ -356,14 +355,16 @@ typedef struct sigevent
FAR struct pthread_attr_s *_attribute;
} _sigev_thread;
-#endif
+
pid_t _tid; /* ID of thread to signal */
} _sigev_un;
-} sigevent_t;
-#define sigev_notify_function _sigev_un._sigev_thread._function
-#define sigev_notify_attributes _sigev_un._sigev_thread._attribute
-#define sigev_notify_thread_id _sigev_un._tid
+# define sigev_notify_function _sigev_un._sigev_thread._function
+# define sigev_notify_attributes _sigev_un._sigev_thread._attribute
+# define sigev_notify_thread_id _sigev_un._tid
Review Comment:
need new Kconfig, sigev_notify_thread_id is totally different from
sigev_notify_function
##########
boards/arm/stm32/stm3240g-eval/configs/knxwm/defconfig:
##########
@@ -6,7 +6,6 @@
# modifications.
#
# CONFIG_ARCH_FPU is not set
-# CONFIG_FS_REFCOUNT is not set
Review Comment:
ditto
##########
fs/Kconfig:
##########
@@ -121,11 +121,17 @@ config FS_HEAPSIZE
config FS_REFCOUNT
bool "File reference count"
- default !DEFAULT_SMALL
Review Comment:
if the user care size, defconfig should select DEFAULT_SMALL first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
