anchao commented on code in PR #13519:
URL: https://github.com/apache/nuttx/pull/13519#discussion_r1764321291
##########
include/signal.h:
##########
@@ -356,14 +355,16 @@ typedef struct sigevent
FAR struct pthread_attr_s *_attribute;
} _sigev_thread;
-#endif
+
pid_t _tid; /* ID of thread to signal */
} _sigev_un;
-} sigevent_t;
-#define sigev_notify_function _sigev_un._sigev_thread._function
-#define sigev_notify_attributes _sigev_un._sigev_thread._attribute
-#define sigev_notify_thread_id _sigev_un._tid
+# define sigev_notify_function _sigev_un._sigev_thread._function
+# define sigev_notify_attributes _sigev_un._sigev_thread._attribute
+# define sigev_notify_thread_id _sigev_un._tid
Review Comment:
I don't want to add new options, which will make this feature look worse.
Thread ID notification is also a kind of thread notification. Why couldn‘t use
a configuration to manager them together? a other option should we change the
name of CONFIG_SIG_EVTHREAD?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
