nuttxpr commented on PR #13547: URL: https://github.com/apache/nuttx/pull/13547#issuecomment-2362476918
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13494&type=pullrequests) **No, this PR does not meet the NuttX Requirements.** **Missing Information:** * **Summary:** * **What functional part of the code is being changed?** Be specific. Which files/modules are affected? * **How does the change exactly work?** Provide technical details about how the tick count is manually set. * **Impact:** * **Is new feature added? Is existing feature changed?** Clarify if this is a bug fix, enhancement, or new functionality. * **Impact on user:** Will this change how users interact with the system in any way? * **Impact on build/hardware/documentation/security/compatibility:** You've marked these as "NO," but it's essential to justify why there's no impact in each case, especially for hardware and compatibility, given that you're changing a fundamental timing mechanism. * **Testing:** * **Build Host(s):** Provide details about your development environment (OS, CPU architecture, compiler version). * **Target(s):** Specify the exact architecture, board, and configuration used for testing. * **Testing logs:** The logs are empty. Include relevant log snippets that demonstrate the issue before the change and the improvement after the change. **Recommendations:** 1. **Expand the Summary:** Provide a clear and concise description of the problem being solved and the technical approach used. 2. **Thoroughly Analyze Impact:** Don't just state "NO" for impact. Explain your reasoning. For example, if there's no impact on users, explain why this change is transparent to them. 3. **Provide Detailed Testing Information:** Include specific details about your build environment and target platform. Most importantly, provide relevant log snippets that clearly demonstrate the problem before your change and the positive effect of your change. A well-documented PR is crucial for reviewers to understand your changes and ensure the quality of the NuttX project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
