nuttxpr commented on PR #13987: URL: https://github.com/apache/nuttx/pull/13987#issuecomment-2401997807
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The provided PR summary does not meet all the NuttX requirements. Here's why: **Missing Information:** * **Summary:** * **What functional part of the code is being changed?** Be specific. Is this a change to the scheduler? A specific architecture port? * **How does the change exactly work (what will change and how)?** Provide more technical detail about the cross-core interrupt mechanism and how it's integrated into the scheduling logic. * **Impact:** * **Is new feature added? Is existing feature changed?** Specify which one it is. * While it mentions "RELEASE", more details are needed for all impact categories. **Provide specifics for each "YES"**. For example: * **Impact on hardware:** Which architectures or boards are affected by this change to cross-core task scheduling? * **Impact on compatibility:** Are there any backward compatibility concerns with this new scheduling approach? * **Testing:** * **Build Host(s):** List the specific operating systems, CPUs, and compiler versions used for testing. * **Target(s):** Be specific about the architectures, boards, and configurations tested. * **Testing logs:** The PR should include actual testing logs, not placeholders. **Recommendations:** 1. **Expand the Summary:** Provide more technical details about the code being changed and the mechanism of the new approach. 2. **Complete Impact Assessment:** Address all the impact categories with specific details. Don't just state "RELEASE." Explain what that means in terms of potential user impact, build system changes, etc. 3. **Provide Thorough Testing Information:** Include details about your testing environment and the actual logs demonstrating the functionality before and after your changes. By addressing these points, you'll make your PR much stronger and easier for the NuttX maintainers to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
