nuttxpr commented on PR #2676: URL: https://github.com/apache/nuttx-apps/pull/2676#issuecomment-2406243874
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. The PR as described **does not meet** the NuttX requirements. Here's why: * **Missing Testing Logs:** The "Testing" section mentions verification but doesn't provide actual testing logs from before and after the change. Concrete logs are essential to demonstrate the impact and correctness of the changes. * **Unclear User Impact:** While it mentions the build impact, the PR description doesn't clearly state if there's any impact on users of `nuttx-apps`. Will users need to do anything differently? * **Limited Target Information:** The testing section only mentions Arm32 and RISC-V. To be thorough, it should list *all* target architectures and boards used for testing. **To improve the PR:** 1. **Add Specific Testing Logs:** Include snippets of logs demonstrating the build behavior before and after the changes, focusing on the areas affected (Arm32, RISC-V build times, etc.). 2. **Clarify User Impact:** Explicitly state whether users will experience any changes in functionality or if they need to adapt their workflows. 3. **Provide Comprehensive Target Details:** Enumerate all architectures, boards, and configurations tested to ensure broad coverage and identify potential issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
