lupyuen commented on PR #2676:
URL: https://github.com/apache/nuttx-apps/pull/2676#issuecomment-2408896612

   @raiden00pl You're 100% correct, `arch.yml` is totally not needed in 
`nuttx-apps`. I have difficulty keeping `nuttx/build.yml` and 
`nuttx-apps/build.yml` in sync, that's why I simply copied over `arch.yml` 
as-is.
   
   I suppose in future we could extend `arch.yml` with Build Rules that are 
specific to `nuttx-apps`?
   
   Wonder if we're proposing to remove `nuttx-apps/arch.yml`? This means that 
we need to rewrite the `build.yml` logic from this:
   
   ```yaml
     # Select the Linux Builds based on PR Arch Label
     Linux-Arch:
       uses: apache/nuttx-apps/.github/workflows/arch.yml@master
       needs: Fetch-Source
       with:
         boards: |
           [
             "arm-01", "other", "risc-v-01", "sim-01", "xtensa-01", ...
           ]
   
     # Run the selected Linux Builds
     Linux:
       needs: Linux-Arch
       if: ${{ needs.Linux-Arch.outputs.skip_all_builds != '1' }}
       strategy:
         matrix:
           boards: ${{ fromJSON(needs.Linux-Arch.outputs.selected_builds) }}
   ```
   
   Back to this:
   
   ```yaml
     Linux:
       needs: Fetch-Source
       strategy:
         matrix:
           boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, 
arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, other, risc-v-01, risc-v-02, 
sim-01, sim-02, xtensa-01, xtensa-02]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to