anchao commented on code in PR #14079:
URL: https://github.com/apache/nuttx/pull/14079#discussion_r1797534295
##########
include/nuttx/spinlock.h:
##########
@@ -532,14 +528,7 @@ irqstate_t spin_lock_irqsave_wo_note(FAR volatile
spinlock_t *lock)
if (NULL == lock)
{
- int me = this_cpu();
Review Comment:
> enter_critical_section support the nest lock, spin_lock with NULL ptr
mimic the critical section behavior, it's better to support the similar behavior
Nested spinlock are fictitious demand, and other operating systems do not
provide this capability.which will allow kernel developers to abuse this
feature (fortunately current code base does not use nested spinlock)
> or remove NULL pointer support directly.
This will be another topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
