hujun260 commented on code in PR #14079:
URL: https://github.com/apache/nuttx/pull/14079#discussion_r1797542677
##########
include/nuttx/spinlock.h:
##########
@@ -532,14 +528,7 @@ irqstate_t spin_lock_irqsave_wo_note(FAR volatile
spinlock_t *lock)
if (NULL == lock)
{
- int me = this_cpu();
Review Comment:
If it has no impact on the existing code. This change is fine. Nested
spinlock is indeed very harmful, prone to abuse and leading to a decline in
code quality. Additionally, this functionality is not available in Linux. In
our future plans, nested usage of enter_critical_section will also be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
