JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1807896669
##########
nshlib/nsh_parse.c:
##########
@@ -1047,6 +1058,15 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline,
FAR char **allocation)
{
FAR char *tmpfile;
+ struct nsh_param_s param_exec = {
Review Comment:
> move before line1090
sorry, before1060 maybe? (moved to 1st line of the function)
##########
nshlib/nsh_parse.c:
##########
@@ -2593,9 +2613,15 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s
*vtbl, FAR char *cmdline)
FAR char *argv[MAX_ARGV_ENTRIES];
FAR char *saveptr;
FAR char *cmd;
- FAR char *redirfile_out = NULL;
- FAR char *redirfile_in = NULL;
- int oflags = 0;
+ struct nsh_param_s param_exec = {
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
